chore!: remove deprecated NewMenuEntry.iconClass#1385
Merged
Conversation
susnux
added
type: breaking
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 23 23
Lines 666 666
Branches 181 181
=======================================
Hits 604 604
Misses 51 51
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Nov 27, 2025
Contributor
|
skjnldsv
force-pushed
the
chore/drop-deprecated-new-menu
branch
from
19b2a97 to
eaf8814
Compare
The `iconClass` attribute was deprecated for over 2 years. With v4 it is now removed. Instead use the `iconSvgInline` attribute to pass a svg icon. Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
chore/drop-deprecated-new-menu
branch
from
eaf8814 to
54ddae7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
iconClassattribute was deprecated for over 2 years. With v4 it is now removed.Instead use the
iconSvgInlineattribute to pass a svg icon.