fix: Make types of File and Folder more explicit#1118
Merged
Conversation
Both inherit from Node which is generic, thus e.g. the `mime` field is of type `string`. But for folders the mime can never be something different to `'httpd/unix-directory'`. So the correct type would be the string literal `'httpd/unix-directory'`. The same for the `type` attribute for `File` and `Folder`. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
type: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 23 23
Lines 632 632
Branches 166 166
=======================================
Hits 580 580
Misses 45 45
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Bundle ReportBundle size has no change ✅ |
skjnldsv
approved these changes
Nov 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both inherit from Node which is generic, thus e.g. the
mimefield is of typestring. But for folders the mime can never be something different to'httpd/unix-directory'.So the correct type would be the string literal
'httpd/unix-directory'.The same for the
typeattribute forFileandFolder.⬆️ While this could be seen as an improvement it actually fixes a Typescript issue:
This I expect to work, but it fails with: