fix: Make View methods bound to ViewData object#1068
Closed
Conversation
Use case: You want to scope logic and state into the view rather than somewhere in a module. Problem: The `View` class wraps the `ViewData` as a getter, meaning instead of calling the function on the object, it just returns the reference to the function within the object. This means the function looses the reference to the object as `this`. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
status: needs info
Bundle ReportChanges will increase total bundle size by 106 bytes ⬆️
|
skjnldsv
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case:
You want to scope logic and state into the view rather than somewhere in a module.
Problem:
The
Viewclass wraps theViewDataas a getter, meaning instead of calling the function on the object, it just returns the reference to the function within the object. This means the function looses the reference to the object asthis.Viewto create custom classes #1067Instead of making
Viewa real class that can be extended, this just allows to use statefulViewData.Meaning function like
getContentsandloadChildViewdo not loose thethiscontext, but can still work with it.This is useful to have stateful views, e.g. the favorites view which needs to load children based on a state (nodes added / removed).