fix(guestName): limit length to 64 characters#1915
Conversation
max-nextcloud
force-pushed
the
fix/guest-name-size-limit
branch
from
cd62144 to
9d0220c
Compare
max-nextcloud
force-pushed
the
fix/guest-name-size-limit
branch
from
9d0220c to
4801503
Compare
Depending on the database used this will not work, it is only guaranteed to store 64 bytes then. |
Could you point me to the database in question? According to https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/datatype-limits.html oracle does not seem to be an issue:
Same for Postgres: https://www.postgresql.org/docs/10/datatype-character.html
I also checked mysql and mariadb. sqlite does not have limited length data types afaik. |
But this depends on the encoding used on the database which is not always utf8 (see their mysql variants) |
max-nextcloud
force-pushed
the
fix/guest-name-size-limit
branch
from
4801503 to
6e98445
Compare
This is the same limit we apply to authenticated user display names. The text app stores guest names in a 64 char database field. Note that this is counting characters - not bytes. So languages with multi-byte characters can still use 64 chars in name. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/guest-name-size-limit
branch
from
6e98445 to
ab78849
Compare
|
@susnux adjusted according to your proposal. |
|
/backport to stable6 |
2 participants
This is the same limit we apply to authenticated user display names.
The text app stores guest names in a 64 char database field.
Note that this is counting characters - not bytes.
So languages with multi-byte characters can still use 64 chars in name.