chore: bump ESLint from 8 to 9 with new @nextcloud/eslint-config@9#558
Merged
chore: bump ESLint from 8 to 9 with new @nextcloud/eslint-config@9#558
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
susnux
approved these changes
Jun 21, 2025
| @@ -0,0 +1,8 @@ | |||
| /* | |||
Contributor
Author
There was a problem hiding this comment.
/** is problematic because it has a special meaning - a JSDoc comment.
/* is a general comment and works without any problems as far as I know.
It is a default comment syntax, so it works automatically with tooling.
For example, JetBrains IDEs add/fix/check copyright comments out of the box.
VSCode has many extensions, but some I checked also use a general comment by default.
/*! isn't some standard, requiring manual work. Like adding our own ESLint rule for that. And adapting to other languages. We don't use <!--! in HTML, for example.
Contributor
There was a problem hiding this comment.
Yes its more like most tools I know specially handle *! as legal comment and e.g. preserve it during minification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run lint:fix: