Conversation
Contributor
ShGKme
commented
Jun 21, 2025
ShGKme
commented
- For a library there is no need to transpile to an old ES version. It is covered by the application bundler
- With vitest babel also isn't needed to run tests
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
susnux
reviewed
Jun 21, 2025
susnux
reviewed
Jun 21, 2025
Comment on lines
+4
to
+6
| "target": "esnext", | ||
| "module": "commonjs", | ||
| "declaration": true, | ||
| "moduleResolution": "node", |
Contributor
There was a problem hiding this comment.
Why not directly esnext module?
Contributor
Author
There was a problem hiding this comment.
Because it is a small but breaking change rather than a refactoring
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
chore/remove-babel
branch
from
6e39465 to
ce0054a
Compare
susnux
reviewed
Jun 21, 2025
| "build:doc": "typedoc --excludeNotExported --mode file --out dist/doc lib/index.ts && touch dist/doc/.nojekyll", | ||
| "check-types": "tsc", | ||
| "dev": "babel ./lib --out-dir dist --extensions '.ts,.tsx' --watch", | ||
| "check-types": "tsc --noEmit", |
Contributor
There was a problem hiding this comment.
Suggested change
| "check-types": "tsc --noEmit", | |
| "ts:check": "tsc --noEmit", |
susnux
approved these changes
Jun 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.