import/no-default-export? 😀

import/no-default-export

This is quite drastic, there are at least some good reasons for default exports:

• config files
• Vue components

• config files
• Vue components

can be easily excluded 👀

can be easily excluded 👀

Then lets discuss this in a follow up similar to import ordering

Haven't checked the docs, but can we disable resolving completely?
It seems unnecessary as bundler will check it anyway.
It has many places where it may break, like using <script setup>, especially in mixed environment.

Just checked and yes, still the same issues.

It is not possible to use it in mixed project (TS + JS). Looks like it tries to parse TS file as JS and dies on importing types.

Or maybe we need to set the syntax for import plugin...

Example:

/home/shgk/nextcloud/talk-desktop/src/shared/setupWebPage.js
   9:25  error    Parse errors in imported module '../app/AppData.js': Unexpected token = (19:12)          import/namespace
   9:25  warning  Parse errors in imported module '../app/AppData.js': Unexpected token = (19:12)          import/no-deprecated
  10:29  error    Parse errors in imported module './globals/globals.js': Unexpected token { (58:12)       import/namespace
  10:29  warning  Parse errors in imported module './globals/globals.js': Unexpected token { (58:12)       import/no-deprecated
  14:32  error    Parse errors in imported module '../app/appData.service.js': Unexpected token . (60:24)  import/namespace
  14:32  warning  Parse errors in imported module '../app/appData.service.js': Unexpected token . (60:24)  import/no-deprecated

In AppData.js its

export class AppData {
	serverUrl = null // Line 19 <-----

In globals.js:

	try {
		return require(`@global-styles/core/img/filetypes/${icon}.svg`)
	} catch { // Line 58 <-----
		return undefined
	}

In appData.service.js

if (error.response?.status === 401) { // Line 60 <----

eslint-plugin-import resets ecmaVersion to 2018.

I've pushed a commit to reset it back to latest.

Alternative - set such options after import config.

Another problem:

error  Using exported name 'NcRichText' as identifier for default import  import/no-named-as-default

on

import NcRichText from '@nextcloud/vue/components/NcRichText'

because we export NcRichText twice: as default and as named

export default NcRichText

export {
	NcRichText,
	NcReferenceList,
	NcReferenceWidget,
	NcReferencePicker,
	NcReferencePickerModal,
	NcSearch,

	registerWidget,
	renderWidget,
	isWidgetRegistered,

	NcCustomPickerRenderResult,
	registerCustomPickerElement,
	renderCustomPickerElement,
	isCustomPickerElementRegistered,
	getLinkWithPicker,
	anyLinkProviderId,
	getProvider,
	getProviders,
	sortProviders,
	searchProvider,
}

So the plugin wants to import it:

import { NcRichText } from '@nextcloud/vue/components/NcRichText'
// or
import NcRichTextComponent from '@nextcloud/vue/components/NcRichText'

And another one:

<script lang="ts">
export default {
	inheritAttrs: false,
}
</script>

<script setup lang="ts">
import { ref } from 'vue'

const flag = ref(false)
</script>

fails with

error  Import in body of module; reorder to top  import/first

And, what is awful, ⚠️ it's got auto-fixed to invalid ⚠️

<script setup lang="ts">
import { ref } from 'vue'

export default {
	inheritAttrs: false,
}

const flag = ref(false)
</script>

PS: This is fine:

<script setup lang="ts">
import { ref } from 'vue'

const flag = ref(false)
</script>

<script lang="ts">
export default {
	inheritAttrs: false,
}
</script>

And this is ruined completely.

<script setup lang="ts">
import { ref } from 'vue'

const flag = ref(false)

log(foo)
</script>

<script lang="ts">
import { Foo } from 'foo'

const foo = new Foo()

export default {
	inheritAttrs: false,
}
</script>

Auto-fixed to completely broken component

Proposal: disable import/first completely.

At least TS checks it, and developers seem to follow this rule without linting. While issues with the rule are serious.

• Having all the issues above, proposing closing in flavor of feat: add import and export rules #981

🗑️ in favor of #981