Skip to content

Comments

refactor: use camelCase for internal variables#971

Merged
susnux merged 1 commit intomainfrom
chore/adjust-variable-name
Apr 9, 2025
Merged

refactor: use camelCase for internal variables#971
susnux merged 1 commit intomainfrom
chore/adjust-variable-name

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 9, 2025

Should fix this naming.

@susnux susnux requested a review from ShGKme April 9, 2025 13:24
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, what's the purpose of this meta-property?

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 9, 2025

BTW, what's the purpose of this meta-property?

The first time I used it was for contacts, as vCard contains the version of the client that created them. So here, the contacts app version 😁
I think it's now used for logging and compiling for webpack and vite

@susnux susnux merged commit fe87ec2 into main Apr 9, 2025
10 checks passed
@susnux susnux deleted the chore/adjust-variable-name branch April 9, 2025 14:56
@susnux
Copy link
Contributor Author

susnux commented Apr 9, 2025

@skjnldsv I think you are on the wrong PR ;)

@ShGKme Its required by ESLint and will be shown within the plugin in IDE and debugging

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 9, 2025

@skjnldsv I think you are on the wrong PR ;)

Dammit! 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants