Skip to content

Comments

feat: introduce @nextcloud/vue eslint plugin#939

Merged
Antreesy merged 2 commits intomainfrom
feat/noid/nc-vue-rules
Apr 24, 2025
Merged

feat: introduce @nextcloud/vue eslint plugin#939
Antreesy merged 2 commits intomainfrom
feat/noid/nc-vue-rules

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 24, 2025

POC to see if we can handle deprecated parameters and practices in nextcloud/[email protected]

image

TODO:

  • should be included in .js|.ts files?
  • discuss what's worth efforts to be highlighted with eslint
  • discuss what's worth efforts to be handled with eslint --fix
  • find the first release in nextcloud/[email protected] we started to deprecate something for the next branch that's worth linting

@Antreesy Antreesy added enhancement New feature or request 3. to review labels Mar 24, 2025
@Antreesy Antreesy requested review from ShGKme and susnux March 24, 2025 16:52
@Antreesy Antreesy self-assigned this Mar 24, 2025
@Antreesy Antreesy force-pushed the feat/noid/nc-vue-rules branch from edfce23 to ad2a667 Compare March 24, 2025 16:53
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Antreesy Antreesy force-pushed the feat/noid/nc-vue-rules branch 2 times, most recently from 1b88c14 to 6157364 Compare April 10, 2025 08:36
@Antreesy Antreesy force-pushed the feat/noid/nc-vue-rules branch from 6157364 to 589d881 Compare April 11, 2025 08:54
@Antreesy Antreesy force-pushed the feat/noid/nc-vue-rules branch from c75523b to 7cf70de Compare April 11, 2025 13:23
@Antreesy Antreesy requested a review from ShGKme April 17, 2025 08:56
@Antreesy Antreesy force-pushed the feat/noid/nc-vue-rules branch from 7cf70de to a8fb746 Compare April 24, 2025 14:44
@Antreesy Antreesy force-pushed the feat/noid/nc-vue-rules branch from a8fb746 to cd5d402 Compare April 24, 2025 15:27
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my tests seem to work. Nice work 🚀

Signed-off-by: Maksim Sukharev <[email protected]>
- includes 'no-deprecated-exports' rule

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the feat/noid/nc-vue-rules branch from cd5d402 to e324952 Compare April 24, 2025 21:46
@Antreesy Antreesy merged commit 8fe81a4 into main Apr 24, 2025
10 checks passed
@Antreesy Antreesy deleted the feat/noid/nc-vue-rules branch April 24, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants