fix(l10n-plugin): also check translation strings in n method#1112
fix(l10n-plugin): also check translation strings in n method#1112
n method#1112Conversation
- also check `n` method - use `CallExpression` for visitor (there are more Literals than call expressions, so this should boost performance). Signed-off-by: Ferdinand Thiessen <[email protected]>
|
Unrelated to this PR specifically, but I was sure that we must have a space before |
|
Also unrelated, but there was a 4th undefined argument to these functions, usually |
Do you mean
I think only if its within a sentence representing omitted text, when its on a single word there should be no space. |
|
If you trying to shorten words as i18n, or cut by the max length - it's an ellipsized text, which shouldn't be spaced Otherwise it has different meanin. Ellipsis should IMO be spaced from both sides, if it represents:
|
Which is never the case for l10n string |
nmethodCallExpressionfor visitor (there are more Literals than call expressions, so this should boost performance).