Skip to content

Comments

fix(no-deprecated-props): respect nextcloud/vue library version for the rule#1084

Merged
susnux merged 2 commits intomainfrom
fix/no-deprecated-props-versions
Jul 30, 2025
Merged

fix(no-deprecated-props): respect nextcloud/vue library version for the rule#1084
susnux merged 2 commits intomainfrom
fix/no-deprecated-props-versions

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 18, 2025

Require installed library version check before linting the file

Inspired by nextcloud-libraries/nextcloud-vue#7032 - we should not force the rule or highlight the error, if component is not working correctly in this lib version

Other examples:

const isAriaHiddenValid = versionSatisfies('8.2.0') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/4835
const isDisableSwipeValid = versionSatisfies('8.23.0') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/6452
const isVariantTypeValid = versionSatisfies('8.24.0') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/6472
const isDefaultBooleanFalseValid = versionSatisfies('8.24.0') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/6656
const isDateTimePickerFormatValid = versionSatisfies('8.25.0') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/6738
const isNcSelectKeepOpenValid = versionSatisfies('8.25.0') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/6791
const isNcPopoverNoFocusTrapValid = versionSatisfies('8.26.0') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/6808
const isNcSelectUsersValid = versionSatisfies('8.27.1') // https://github.com/nextcloud-libraries/nextcloud-vue/pull/7032

@Antreesy Antreesy requested review from ShGKme and susnux June 18, 2025 15:20
@Antreesy Antreesy self-assigned this Jun 18, 2025
@Antreesy Antreesy added bug Something isn't working 3. to review labels Jun 18, 2025
@Antreesy Antreesy force-pushed the fix/no-deprecated-props-versions branch from 2a82cc8 to d050c70 Compare June 18, 2025 15:21
susnux
susnux reviewed Jun 18, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/no-deprecated-props-versions branch from d050c70 to 195b292 Compare June 18, 2025 17:11
@susnux susnux merged commit d358a2e into main Jul 30, 2025
7 checks passed
@susnux susnux deleted the fix/no-deprecated-props-versions branch July 30, 2025 12:11
@susnux susnux mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Antreesy @susnux