feat(nextcloud-vue): add rule for deprecated NcButton props#1045
Conversation
96a17c5 to
275c533
Compare
|
Is it possible to check the following? I didn't get from the code: |
lib/plugins/nextcloud-vue/index.ts
Outdated
| version: packageVersion, | ||
| }, | ||
| } satisfies ESLint.Plugin | ||
| } as unknown as ESLint.Plugin |
There was a problem hiding this comment.
Due to mismatch between ESLint type of rules and the typescript wrapper
There was a problem hiding this comment.
Can we fix mismatch instead?
This comment was marked as resolved.
This comment was marked as resolved.
|
@Antreesy this |
|
Also what I did not implement to keep it simple: Aliasing the component. <template
<Button ...>
</template>
<script setup>
import Button from '@nextcloud/vue/components/NcButton'
</script>Not sure if this is useful |
need to check I'd be happy to cover 'ConditionalExpression' at least, then it's not much left to check manually |
It's from the time when there was no |
I'd say if you do not follow styleguide - that's your problem 😀 |
275c533 to
3924279
Compare
d859a9e to
e97532a
Compare
|
New approach fails at Talk: Failing button: <NcButton v-show="!loading"
type="tertiary"
:title="t('spreed', 'Delete this server')"
:aria-label="t('spreed', 'Delete this server')"
@click="removeServer">
<template #icon>
<IconDelete :size="20" />
</template>
</NcButton> |
3ce2d5c to
47bad4c
Compare
Thats |
- for #1001 Signed-off-by: Ferdinand Thiessen <[email protected]>
47bad4c to
4d28fd3
Compare
This is otherwise really a mess to migrate 🙈