fix(typescript): allow import in type annotation#1034
Merged
Conversation
Contributor
I did see this 🙈 |
susnux
approved these changes
May 13, 2025
lib/configs/typescript.ts
Outdated
| // Do not allow to import types with `import` but require `import type` | ||
| '@typescript-eslint/consistent-type-imports': 'error', | ||
| // Except for type annotations, where dynamic import are often used, for example, in .d.ts files | ||
| '@typescript-eslint/consistent-type-imports': ['error', { disallowTypeAnnotations: false }], |
Contributor
There was a problem hiding this comment.
IMHO makes sense iff used in d.ts
Contributor
Author
ok :( |
ShGKme
force-pushed
the
fix/consistent-type-imports-in-annotations
branch
from
cf51d0b to
340f1e5
Compare
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/consistent-type-imports-in-annotations
branch
from
340f1e5 to
d3c9234
Compare
Contributor
Author
|
@susnux What do you think about the current approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
By default
@typescript-eslint/consistent-type-importsforbids dynamic import for type annotations like:But for declaration files
.d.tsit is important. Otherwise it becomes a module.