Skip to content

Comments

fix: deprecate npm token publishing and use trusted publisher#98

Merged
skjnldsv merged 1 commit intomainfrom
skjnldsv-patch-1
Dec 11, 2025
Merged

fix: deprecate npm token publishing and use trusted publisher#98
skjnldsv merged 1 commit intomainfrom
skjnldsv-patch-1

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 11, 2025 •
edited
Loading

@skjnldsv skjnldsv self-assigned this Dec 11, 2025
skjnldsv added a commit to nextcloud-libraries/nextcloud-vue that referenced this pull request Dec 11, 2025
@skjnldsv
fix: drop npm token publishing and use trusted publisher
4a9220e 
nextcloud-libraries/.github#98

Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv added a commit to nextcloud-libraries/nextcloud-files that referenced this pull request Dec 11, 2025
@skjnldsv
fix: drop npm token publishing and use trusted publisher
817d5d3 
nextcloud-libraries/.github#98

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv mentioned this pull request Dec 11, 2025
Merged
backportbot bot pushed a commit to nextcloud-libraries/nextcloud-files that referenced this pull request Dec 11, 2025
@skjnldsv @backportbot
fix: drop npm token publishing and use trusted publisher
e7769f8 
nextcloud-libraries/.github#98

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv enabled auto-merge December 11, 2025 08:37
@skjnldsv skjnldsv merged commit 0a45ac8 into main Dec 11, 2025
7 of 8 checks passed
@skjnldsv skjnldsv deleted the skjnldsv-patch-1 branch December 11, 2025 08:42
@ChristophWurst
Copy link
Contributor

ChristophWurst commented Dec 11, 2025 •
edited
Loading

And I was already wondering why I'm now getting emails for releases. Thanks!

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Dec 11, 2025

And I was already wondering why I'm now getting emails for releases. Thanks!

You mean why you were NOT receiving emails ?
Npm always sends emails to owners/admins of the npm org @nextcloud :)

@skjnldsv skjnldsv mentioned this pull request Dec 11, 2025
Open
@ChristophWurst
Copy link
Contributor

ChristophWurst commented Dec 11, 2025 •
edited
Loading

I'm pretty sure I only got emails before when my PAT was used. But today I got Successfully published @nextcloud/[email protected]. This is new

@susnux
Copy link
Contributor

susnux commented Dec 11, 2025

⚠️ this does not work:

Trusted publishing currently supports:
GitHub Actions (GitHub-hosted runners)
GitLab CI/CD Pipelines (GitLab.com shared runners)

Self-hosted runners are not currently supported but are planned for future releases.

It requires forcing this workflow to run on GitHub runners

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Dec 11, 2025

It requires forcing this workflow to run on GitHub runners

We do not use them on this org :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@susnux susnux Awaiting requested review from susnux

@ShGKme ShGKme Awaiting requested review from ShGKme

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@skjnldsv skjnldsv

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @ChristophWurst @susnux @nickvergessen