fix(viewer): address file path composition for subfolders in public shares#2991
fix(viewer): address file path composition for subfolders in public shares#2991
Conversation
skjnldsv
force-pushed
the
filter-bug-shared-subfolder
branch
from
ab52cab to
6aa255e
Compare
|
/compile |
|
/backport to stable31 |
|
/backport to stable30 |
This comment was marked as resolved.
This comment was marked as resolved.
…n subfolders in a file share. Previously, node.path for files ina a shaer were `/${file.basename}`
Fixes #2977
Fixes #2976
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
skjnldsv
force-pushed
the
filter-bug-shared-subfolder
branch
from
d762ad0 to
71838a3
Compare
backportbot
bot
removed
the
backport-request
|
/backport to stable32 |
backportbot
bot
removed
the
backport-request
|
/backport to stable31 |
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/2991/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d2ec1cd7 71838a32
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2991/stable31Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2991/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2991/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d2ec1cd7 71838a32
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2991/stable30Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2991/stable30."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/2991/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d2ec1cd7 71838a32
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2991/stable32Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2991/stable32."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
While the fix merged in nextcloud#2991 addressed a share, it inadvertently broke navigating through images for regular file viewing. This fix uses the `join`, `dirPath` and `node.basename` to reconstruct the paths that works for both shares and non-shared views. Signed-off-by: tabedzki <[email protected]>
4 participants
Closes #2980
Fixes #2977
Fixes #2976
Fixes #2990