Skip to content

Comments

feat(viewer): allow async handler components#2077

Merged
juliusknorr merged 1 commit intomasterfrom
pulsejet/async-handler
Nov 28, 2023
Merged

feat(viewer): allow async handler components#2077
juliusknorr merged 1 commit intomasterfrom
pulsejet/async-handler

Conversation

@pulsejet
Copy link
Member

@pulsejet pulsejet commented Nov 27, 2023 •
edited
Loading

Allows use of async handlers

OCA.Viewer.registerHandler({
	id: 'text',
	component: () => import('./components/ViewerComponent.vue'),
})

For nextcloud/text#4698

@pulsejet pulsejet added enhancement New feature or request 3. to review Waiting for reviews labels Nov 27, 2023
@pulsejet pulsejet mentioned this pull request Nov 27, 2023
Merged
@pulsejet pulsejet force-pushed the pulsejet/async-handler branch from 72749ce to 061bacb Compare November 27, 2023 20:20
juliusknorr
juliusknorr approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, thanks for that 👍

@juliusknorr juliusknorr merged commit 15da8b5 into master Nov 28, 2023
@juliusknorr juliusknorr deleted the pulsejet/async-handler branch November 28, 2023 08:29
@pulsejet
Copy link
Member Author

pulsejet commented Nov 29, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Nov 29, 2023
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Nov 29, 2023
@github-actions
Copy link

github-actions bot commented Dec 12, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement New feature or request feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pulsejet @juliusknorr