Skip to content

Comments

Replace id to class for files app#1298

Merged
nickvergessen merged 2 commits intomasterfrom
bugfix/noid/replace-files-dom-ids
Jul 26, 2022
Merged

Replace id to class for files app#1298
nickvergessen merged 2 commits intomasterfrom
bugfix/noid/replace-files-dom-ids

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Jul 22, 2022

For nextcloud/server#33320

  • test with cypress workflow pointing at the above PR (I didn't find how to do it with the docker)
  • revert cypress workflow once server/master PR is merged

@PVince81 PVince81 force-pushed the bugfix/noid/replace-files-dom-ids branch from f1e61e3 to aea73cb Compare July 26, 2022 07:51
@PVince81
Copy link
Member Author

seems BRANCH might not be working, need to check inside the dockers

@PVince81 PVince81 force-pushed the bugfix/noid/replace-files-dom-ids branch from aea73cb to 4c6f81f Compare July 26, 2022 10:22
@PVince81 PVince81 requested review from CarlSchwan and artonge July 26, 2022 10:22
@PVince81 PVince81 marked this pull request as ready for review July 26, 2022 10:23
@PVince81
Copy link
Member Author

all green, please approve @artonge @CarlSchwan

@nickvergessen nickvergessen merged commit 402334f into master Jul 26, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/replace-files-dom-ids branch July 26, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants