Merged
Conversation
joshtrichards
force-pushed
the
jtr/lib-updater-strict-types
branch
from
2233352 to
8f8ea13
Compare
Signed-off-by: Josh <[email protected]>
joshtrichards
force-pushed
the
jtr/lib-updater-strict-types
branch
from
6a5f9ec to
23c0cb0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
come-nc
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
Altahrim
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works for me locally / passes all tests. Probably a good idea. Maybe for v30, but not to backport.
The only thing I had to change was a minor non-operational adjustment (in
buildVersionFile.php).