Config value to allow to extend .user.ini on update#471
Conversation
makoehr
force-pushed
the
extend-user-ini-with-lines-from-configuration
branch
2 times, most recently
from
d58fa17 to
34aba9a
Compare
makoehr
changed the title
makoehr
force-pushed
the
extend-user-ini-with-lines-from-configuration
branch
from
34aba9a to
4d14bab
Compare
|
Hi, could someone do a review on this pull request? |
|
@Altahrim , could you please have a look at this pull request? Thanks. |
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Hey, sorry it took so long, just to make sure, because I could not see that anywhere else.
user_ini_additional_lines isn't an official config.php property, no?
If so, before we can move forward with that PR, you'll have to officially add user_ini_additional_lines support on https://github.com/nextcloud/server
Please see nextcloud/server#54552 |
skjnldsv
force-pushed
the
extend-user-ini-with-lines-from-configuration
branch
2 times, most recently
from
79d0df0 to
b3abd9d
Compare
|
Thanks Mathias! I rebased and changed your commits to be compliant with our conventional commits requirements. |
|
Btw, please refrain from clicking the update button. It creates merge commits that makes it harder to have a clean commit history :) |
Thanks a lot for the support |
skjnldsv
force-pushed
the
extend-user-ini-with-lines-from-configuration
branch
2 times, most recently
from
c302012 to
b318478
Compare
When running nextcloud with a web hoster it might be necessary to extend .user.ini after each update (e.g. adding memory_limit). To automate this step, an additional config entry may be provided in config.php that specifies the lines to be added to .user.ini. If the config option 'user_ini_additional_lines' exists, the provided value (string or array of strings) will be added to .user.ini. Signed-off-by: Mathias Koehrer <[email protected]> Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
extend-user-ini-with-lines-from-configuration
branch
from
b318478 to
a0c5f9f
Compare
|
Took long enough, but thank you @makoehr ! 🙇 |
5 participants
When running nextcloud with a web hoster it might be necessary to extend .user.ini after each update (e.g. adding memory_limit). To automate this step, an additional config entry may be provided in config.php that specifies the lines to be added to .user.ini.
If the config option 'user_ini_additional_lines' exists, the provided value (string or array of strings) will be added to .user.ini.