fix(deps): bump @nextcloud/password-confirmation from v5 to v6#1674
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
9c66ba1 to
4b4536e
Compare
Member
Author
|
/compile amend / |
4b4536e to
5dd9102
Compare
Signed-off-by: Christoph Wurst <[email protected]> Signed-off-by: nextcloud-command <[email protected]> Signed-off-by: Christoph Wurst <[email protected]>
5dd9102 to
3000bdc
Compare
Member
Author
Antreesy
approved these changes
Nov 28, 2025
susnux
reviewed
Nov 28, 2025
Comment on lines
+71
to
+76
| "moduleNameMapper": { | ||
| "^@nextcloud/password-confirmation$": "<rootDir>/node_modules/@nextcloud/password-confirmation/dist/index.mjs", | ||
| "^@nextcloud/vue/components/NcDialog$": "<rootDir>/node_modules/@nextcloud/vue/dist/components/NcDialog/index.mjs", | ||
| "^@nextcloud/vue/components/NcPasswordField$": "<rootDir>/node_modules/@nextcloud/vue/dist/components/NcPasswordField/index.mjs", | ||
| "^@nextcloud/vue/functions/dialog$": "<rootDir>/node_modules/@nextcloud/vue/dist/functions/dialog/index.mjs" | ||
| }, |
There was a problem hiding this comment.
I was super confused about this but seems like this uses jest so maybe migrating to vitest would remove all that configs :)
Member
Author
There was a problem hiding this comment.
yes, it's on my list 👷
Member
Author
There was a problem hiding this comment.
(I still have to migrate from webpack to vite)
There was a problem hiding this comment.
(I still have to migrate from webpack to vite)
That is not needed for vitest,the testing framework is independent from the bundler (we also used vitest + webpack in server).
Member
Author
There was a problem hiding this comment.
Good to know! I was misled by "A Vite-native testing framework."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Supersedes #1593