Skip to content

fix(deps): bump @nextcloud/password-confirmation from v5 to v6#1674

Merged
ChristophWurst merged 1 commit into
masterfrom
fix/deps/password-confirmation-6
Nov 28, 2025
Merged

fix(deps): bump @nextcloud/password-confirmation from v5 to v6#1674
ChristophWurst merged 1 commit into
masterfrom
fix/deps/password-confirmation-6

Conversation

@ChristophWurst
Copy link
Copy Markdown
Member

Supersedes #1593

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ChristophWurst ChristophWurst force-pushed the fix/deps/password-confirmation-6 branch from 9c66ba1 to 4b4536e Compare November 28, 2025 09:49
@ChristophWurst
Copy link
Copy Markdown
Member Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/deps/password-confirmation-6 branch from 4b4536e to 5dd9102 Compare November 28, 2025 09:52
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the fix/deps/password-confirmation-6 branch from 5dd9102 to 3000bdc Compare November 28, 2025 11:56
@ChristophWurst
Copy link
Copy Markdown
Member Author

image

^ proof that it works :)

Copy link
Copy Markdown

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit (didn't test) =)
Although library is working on Vue 3 and compatible with Vue 2, there's not much frontend code in general, so migration to Vue 3 would be the right and easy next step (should also reduce the app size)

@ChristophWurst ChristophWurst merged commit 14232c6 into master Nov 28, 2025
25 checks passed
@ChristophWurst ChristophWurst deleted the fix/deps/password-confirmation-6 branch November 28, 2025 12:35
Comment thread package.json
Comment on lines +71 to +76
"moduleNameMapper": {
"^@nextcloud/password-confirmation$": "<rootDir>/node_modules/@nextcloud/password-confirmation/dist/index.mjs",
"^@nextcloud/vue/components/NcDialog$": "<rootDir>/node_modules/@nextcloud/vue/dist/components/NcDialog/index.mjs",
"^@nextcloud/vue/components/NcPasswordField$": "<rootDir>/node_modules/@nextcloud/vue/dist/components/NcPasswordField/index.mjs",
"^@nextcloud/vue/functions/dialog$": "<rootDir>/node_modules/@nextcloud/vue/dist/functions/dialog/index.mjs"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was super confused about this but seems like this uses jest so maybe migrating to vitest would remove all that configs :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's on my list 👷

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I still have to migrate from webpack to vite)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I still have to migrate from webpack to vite)

That is not needed for vitest,the testing framework is independent from the bundler (we also used vitest + webpack in server).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! I was misled by "A Vite-native testing framework."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants