Only overwrite Ctrl-f when text is focussed#988
Merged
juliusknorr merged 2 commits intomasterfrom Aug 26, 2020
Merged
Conversation
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
23 tasks
Contributor
|
Code looks good to me. 🧐 Minor nitpick: Maybe put the plugin into a separate class like |
azul
approved these changes
Aug 26, 2020
Contributor
azul
left a comment
azul
left a comment
There was a problem hiding this comment.
Confirmed that it fixes the issue in files.
Keeps using browser search when opening a file in the viewer and looking at the sidebar. I think that is the behavior we want.
I have not played with this in talk.
Closed
Member
Author
|
/backport 52a20e2 to stable19 |
Member
Author
|
/backport 52a20e2 to stable18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise the unified search does not trigger properly if a rich workspace is shown. With this PR the browser default search will be only triggered by text if the keydown event is triggered on the editor input.
Using the regular fallback with hitting Ctrl-F twice would not work here since when editing in the viewer the unified search is hidden in the background and therefore the user doesn't get any feedback when hitting ctrl-f for the first time. Also when having the text focused I think that searching in it is a sane default.