fix/button variant primary#7815
Merged
Merged
Conversation
Collaborator
max-nextcloud
commented
Oct 21, 2025
max-nextcloud
commented
- chore(update): use variant rather than type
- chore(update): rename state.type to actionType
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7815 +/- ##
==========================================
+ Coverage 52.89% 59.68% +6.79%
==========================================
Files 500 500
Lines 43278 38350 -4928
Branches 1062 1062
==========================================
- Hits 22890 22889 -1
+ Misses 20282 15355 -4927
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mejo-
approved these changes
Oct 21, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks for tackling this! Code changes look good to me, prettier is unhappy though.
max-nextcloud
force-pushed
the
fix/button-variant-primary
branch
from
dad7d9a to
e063c47
Compare
NcButton and NcActions now use the variant prop. Signed-off-by: Max <[email protected]>
This way the type is not passed as a prop on `v-bind=state` binding. Signed-off-by: Max <[email protected]>
mejo-
force-pushed
the
fix/button-variant-primary
branch
from
45d2170 to
a271cd8
Compare
Signed-off-by: Max <[email protected]>
mejo-
force-pushed
the
fix/button-variant-primary
branch
from
a271cd8 to
76baa06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.