fix(files): switch action button to disabled state if results are empty#6799
Merged
max-nextcloud merged 1 commit intomainfrom Dec 19, 2024
Conversation
Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
requested review from
max-nextcloud and
mejo-
as code owners
23 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6799 +/- ##
==========================================
+ Coverage 46.76% 46.78% +0.01%
==========================================
Files 748 740 -8
Lines 34162 34150 -12
Branches 1242 1234 -8
==========================================
Hits 15976 15976
+ Misses 17564 17560 -4
+ Partials 622 614 -8 ☔ View full report in Codecov by Sentry. |
max-nextcloud
approved these changes
Dec 19, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
I did not test it but the change makes sense.
max-nextcloud
deleted the
fix/6152-Show-assistant-results-does-not-have-any-results-shown-(emptycontent)
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Assistant bugs: Show assistant results does not have any results shown (emptycontent)
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)