fix(files): set focus on image description right after inserting#6609
Merged
fix(files): set focus on image description right after inserting#6609
Conversation
Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
requested review from
max-nextcloud and
mejo-
as code owners
23 tasks
mejo-
approved these changes
Nov 6, 2024
Member
|
Thanks for tackling this. I'd suggest to backport the fix to stable30 and stable29 at least. |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/compile amend / |
This was referenced Nov 7, 2024
Member
|
@JuliaKirschenheuter there's no need to compile PRs before merging them in the text repo (even though it's a shipped app). We have a CI job that does this after the merge in this repo - which greatly simplifies working with PRs. |
|
If #6843 is caused by this, the inconvenience created is larger than what was fixed by this mr. The focusing is inconsistent anyway, for example crating a note (warn, info etc..) does not focus it. |
2 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Set focus on image description right after inserting
After inserting an attachment, focus should go after the the image -> to the image description
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)