fix(LinkBubble): Treat links to hashes in same page directly#5521
Merged
Conversation
mejo-
force-pushed
the
fix/link_bubble_hash_to_same_page
branch
2 times, most recently
from
7d137e6 to
60d10f9
Compare
mejo-
force-pushed
the
fix/link_bubble_hash_to_same_page
branch
3 times, most recently
from
78d21af to
d37e525
Compare
max-nextcloud
approved these changes
Mar 21, 2024
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
looks good to me. Linter fails though.
Member
Author
Linter failure was a CI hickup. But the Cypress failures might be related. Will have to look into them next week. |
mejo-
force-pushed
the
fix/link_bubble_hash_to_same_page
branch
from
d37e525 to
d0e25e2
Compare
mejo-
force-pushed
the
fix/link_bubble_hash_to_same_page
branch
from
d0e25e2 to
d1ce2e0
Compare
Fixes: #5495 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/link_bubble_hash_to_same_page
branch
from
d1ce2e0 to
c89a0aa
Compare
Member
Author
|
/backport to stable29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5495
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)