Skip to content

Comments

Add new text file action label#4083

Merged
juliusknorr merged 1 commit intomainfrom
enh/a11y-create-new-label
Apr 28, 2023
Merged

Add new text file action label#4083
juliusknorr merged 1 commit intomainfrom
enh/a11y-create-new-label

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Apr 27, 2023

📝 Summary

API changes require the above PR to be merged first

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@Pytal
Copy link
Member Author

Pytal commented Apr 27, 2023

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/a11y-create-new-label branch from f80447a to 2274fd1 Compare April 27, 2023 03:12
@cypress
Copy link

cypress bot commented Apr 27, 2023

2 flaky tests on run #9529 ↗︎

0 142 1 0 Flakiness 2

Details:

Add new text file action label
Project: Text Commit: c92c286c85
Status: Passed Duration: 03:48 💡
Started: Apr 27, 2023 7:30 PM Ended: Apr 27, 2023 7:34 PM
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  propfind.spec.js • 1 flaky test

View Output Video

Test Artifacts
Text PROPFIND extension > with workspaces enabled > always adds rich workspace property Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member

Server PR merged, restarted cypress tests. Static analysis is expected to fail until the next ocp meta package update.

@Pytal Pytal marked this pull request as draft April 27, 2023 16:54
@Pytal
Copy link
Member Author

Pytal commented Apr 27, 2023

Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr force-pushed the enh/a11y-create-new-label branch from 2274fd1 to c92c286 Compare April 27, 2023 19:26
@juliusknorr juliusknorr marked this pull request as ready for review April 28, 2023 05:59
@juliusknorr juliusknorr merged commit bf1272e into main Apr 28, 2023
@juliusknorr juliusknorr deleted the enh/a11y-create-new-label branch April 28, 2023 05:59
@juliusknorr
Copy link
Member

Manually bumped ocp and it is passing https://github.com/nextcloud/text/actions/runs/4827564521/jobs/8600422284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants