Conversation
|
@jancborchardt for some design input (screen recording is in the first post) |
|
Cool stuff! Some first design points:
|
|
@jancborchardt Thanks for the input, all fixed 😉 |
8c1e566 to
fd6bf0a
Compare
|
@jancborchardt @nextcloud/designers Some things that we should consider:
What do you think? |
Yup, like 3.5 rows would be good, with a fade to white at the bottom. When you click it, quick animation to open.
Yep. I see this as very similar to Recommendations toggle in bottom left Files settings #108. We should have the setting saying ☑️ Show rich workspace
I’d say let’s go for the same width for now, just to keep it consistent as it’s specifically for readability. One thing: The "a few seconds ago" should move further to the left so it’s kind of flush right with the end of the text instead of floating in space there. (Cutting that specifically to "seconds ago" would also help.)
Let’s keep it simple for now. README.md is the standard that GitHub and GitLab also use now, so this is established and some folders might even have that. We should of course also make sure that files like readme.md or Readme.md are shown – and maybe actually we should have the default casing be "Readme.md" to look less imposing to people who are not in the know about this? |
|
I'd not have a footer with this, just a header. And using just readme.md makes sense, too. The rest gets complicated. The use case of a fixed footer for example - that can be done with the current README.MD app anyway. I think it's important to think about rendering for public links, though - if a folder is editable, it should be editable, otherwise it should just show. A great way to add a note to a shared folder! Sadly it can't replace the existing 'add a note' as that is share-specific and of course also works on files. |
00a9f55 to
7f9d422
Compare
|
great. makes sense! |
ba450dd to
179a33c
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Bumps [eslint-config-nextcloud](https://github.com/nextcloud/eslint-config-nextcloud) from 0.0.6 to 0.1.0. - [Release notes](https://github.com/nextcloud/eslint-config-nextcloud/releases) - [Commits](nextcloud-libraries/eslint-config@v0.0.6...v0.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
179a33c to
f9469bb
Compare


ToDo
Requires nextcloud/server#17482