Closed
Conversation
2 tasks
Member
|
Should we rather fix this in the viewer or even the |
Member
|
Reference issue would be nextcloud-libraries/nextcloud-vue#2501 |
Member
Author
|
/rebase |
nextcloud-command
force-pushed
the
fix/prevent-focus-to-go-back-to-file-list
branch
from
113b9d3 to
cc762b9
Compare
Member
Author
|
/rebase |
Signed-off-by: Vinicius Reis <[email protected]>
nextcloud-command
force-pushed
the
fix/prevent-focus-to-go-back-to-file-list
branch
from
cc762b9 to
608febe
Compare
Member
|
@vinicius73 I'd say lets skip this one and open a PR in viewer. Or would there be a reason to have it in both? |
Member
Author
|
@juliushaertl we can wait this PR release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
role="dialog"in toEditorWrappercomponent when it is wrapped withViewerComponentRepated to:
nextcloud/viewer#1289