Merged
Conversation
18 tasks
luka-nextcloud
changed the title
mejo-
reviewed
May 26, 2022
src/components/SessionList.vue
Outdated
| </button> | ||
| <template #default> | ||
| <div class="session-menu"> | ||
| <p class="last-saved">Last saved: {{ lastSavedString }}</p> |
Member
There was a problem hiding this comment.
"Last saved" should probably be a translation string.
luka-nextcloud
force-pushed
the
feature/improve-collaborators
branch
from
99519e2 to
589887d
Compare
luka-nextcloud
force-pushed
the
feature/improve-collaborators
branch
from
589887d to
3512d42
Compare
vinicius73
reviewed
Jun 3, 2022
Comment on lines
325
to
338
| saveStatusClass() { | ||
| if (this.syncError && this.lastSavedString !== '') return 'save-error' | ||
| return this.dirtyStateIndicator ? 'saving-status' : 'saved-status' | ||
| }, |
Member
There was a problem hiding this comment.
We can turn it more readable.
Suggested change
| saveStatusClass() { | |
| if (this.syncError && this.lastSavedString !== '') return 'save-error' | |
| return this.dirtyStateIndicator ? 'saving-status' : 'saved-status' | |
| }, | |
| saveStatusClass() { | |
| if (this.syncError && this.lastSavedString !== '') { | |
| return 'save-error' | |
| } | |
| return this.dirtyStateIndicator ? 'saving-status' : 'saved-status' | |
| }, |
src/components/SessionList.vue
Outdated
Comment on lines
140
to
148
| if (this.showAuthorAnnotations) { | ||
| return { | ||
| border: 'solid 2px ' + session.color + ' !important', | ||
| } | ||
| } else { | ||
| return { | ||
| border: 'solid 2px var(--color-main-background) !important', | ||
| 'background-color': session.color + ' !important', | ||
| } |
Member
There was a problem hiding this comment.
We can avoid else here.
Suggested change
| if (this.showAuthorAnnotations) { | |
| return { | |
| border: 'solid 2px ' + session.color + ' !important', | |
| } | |
| } else { | |
| return { | |
| border: 'solid 2px var(--color-main-background) !important', | |
| 'background-color': session.color + ' !important', | |
| } | |
| if (this.showAuthorAnnotations) { | |
| return { | |
| border: 'solid 2px ' + session.color + ' !important', | |
| } | |
| } | |
| return { | |
| border: 'solid 2px var(--color-main-background) !important', | |
| 'background-color': session.color + ' !important', | |
| } |
src/components/SessionList.vue
Outdated
Comment on lines
44
to
46
| <p class="last-saved"> | ||
| {{ t('text', 'Last saved') }}: {{ lastSavedString }} | ||
| </p> |
Member
There was a problem hiding this comment.
We can use slot and remove the necessity of the prop lastSavedString.
Contributor
Author
|
@vinicius73 Please check again. :) |
luka-nextcloud
force-pushed
the
feature/improve-collaborators
branch
2 times, most recently
from
d7e25ca to
9bddd02
Compare
vinicius73
approved these changes
Jun 23, 2022
Member
|
/rebase |
nextcloud-command
force-pushed
the
feature/improve-collaborators
branch
from
9bddd02 to
829677e
Compare
Member
|
/rebase |
nextcloud-command
force-pushed
the
feature/improve-collaborators
branch
from
829677e to
7ca61f2
Compare
Member
|
/compile amend |
Signed-off-by: Luka Trovic <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
feature/improve-collaborators
branch
from
7ca61f2 to
dfbaece
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic [email protected]