Conversation
|
The image still has a rather small max-height though, as seen from the padding on the left and right? The images could get a |
|
@jancborchardt |
c99ddda to
a2ac8f4
Compare
src/nodes/ImageView.vue
Outdated
| .image__main { | ||
| max-height: 40vh; | ||
| img { | ||
| width: 100%; |
There was a problem hiding this comment.
| width: 100%; | |
| max-width: 100%; |
Should still be max-width, otherwise portrait images would be stretched.
|
@jancborchardt The max-height was picked deliberately iirc also in discussion with you at some point to always make the image fit into the visible area. I'd be fine to drop, just want to double check that this is fine with you then. 100vh would not take into account that there is also a menubar visible, so ideally it should be |
No you’re right, the max-height should be kept also, ideally with the value you propose. :) |
src/nodes/ImageView.vue
Outdated
| } | ||
|
|
||
| .image__main { | ||
| max-height: 80vh; |
There was a problem hiding this comment.
| max-height: 80vh; | |
| max-height: calc(100vh - 50px - 50px); |
|
@luka-nextcloud THen with my two code suggestions this would be good 👍 |
a2ac8f4 to
9bd0558
Compare
|
@juliushaertl Fixed :) |
9bd0558 to
9a9a802
Compare
|
/compile amend / |
Signed-off-by: Luka Trovic <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
9a9a802 to
93e502b
Compare
Signed-off-by: Luka Trovic [email protected]
Resolves: ✨ Text app design review #1075
Possibly remove max-height for landscape pictures (ref Jos’ screenshot issue when zooming)Target version: master
Summary
Fix landscape pictures position issue.

