Conversation
9cd5925 to
2d5ca51
Compare
|
Having a bit of text in it I'm no longer sure if we should actually go with the blur here, which we initially discussed with @jancborchardt. Feels a bit less out of place compared to the general Nextcloud design: Screen.Recording.2021-11-24.at.21.35.37.mov@nimishavijay Maybe you also have some thoughts about that? Other than that, there are a few further things that should be more aligned with the increase of the formatting buttons.
|
|
I think with text behind the formatting bar it is a bit confusing, because initially I couldn't tell that it was blurred text, I thought the colour of the bar changed to a weird grey. It looks really nice with images though. I suggest we do something like add gradient from 100% opacity at the middle of the formatting bar to 0% at the bottom along with the blur, so it is not a hard stop but a softer gradient. What do you think? |
|
@jancborchardt @juliushaertl What do you think about @nimishavijay 's suggestion? |
|
I don't see a way with CSS to fade out the blur effect (which itself also doesn't work in some browsers). @jancborchardt Do you have strong feeling about the blur at all? I feel the design is much cleaner and more structured without now looking at the recording another time. |
Yeah, agree with you, don’t have a strong feeling about the blur – the current state looks better and less jarring. Similarly, as soon as the document is loaded, the header bar (where title and top right actions are in) should be fully opaque so the Nextcloud header does not shine through. |
2d5ca51 to
3d0b175
Compare
|
@juliushaertl Please check again.
|
|
/rebase |
3d0b175 to
b0bbafd
Compare
|
/compile amend / |
b0bbafd to
8ef136c
Compare
Looks really goodat first sight. In particular scrolling workspaces without messing with the menubar is great.
👍
Confirmed in viewer. looks good.
Confirmed. Changing the margin in SessionList.vue to I'll create a new commit on top of this to apply these changes. |
julien-nc
left a comment
There was a problem hiding this comment.
- The top/bottom margin of
.avatardiv.icon-groupis 0 and the one of.avatar-wrapperis 6px so they are not aligned:

As the menubar elements and the save-status are already aligned, we could just remove the margin of .avatar-wrapper:
.avatar-wrapper {
margin: 0 -8px 0 0;
}-
Why not generating avatars in 44x44px instead of 32x32px in SessionList's template?
-
Inline suggestions
@luka-nextcloud is this something you could adjust here too? It’s sort of separate but makes the formatting bar look off since the Nextcloud header shines through above. |
Signed-off-by: Luka Trovic <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Max <[email protected]>
517e9b7 to
4343cbd
Compare
|
I rebased and addressed all changes proposed by @eneiluj . |
My understanding is that the top header bar with hte nextcloud shining through is part of the viewer - not the text app. As far as i know we can only pick a light or a dark theme for the viewer. |
Yes... looks much better. Will do this. |
Signed-off-by: Max <[email protected]>


Signed-off-by: Luka Trovic [email protected]
Resolves: ✨ Text app design review #1075
Increase height of formatting bar to 50px, size of avatars to 44 (might fix the status bubble display issue too)A little transparency and blur for more open feelTarget version: master
Summary