Skip to content

Comments

fix issues on formatting bar#1960

Merged
julien-nc merged 3 commits intomasterfrom
update/formatting-bar
Jan 24, 2022
Merged

fix issues on formatting bar#1960
julien-nc merged 3 commits intomasterfrom
update/formatting-bar

Conversation

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Nov 23, 2021

Signed-off-by: Luka Trovic [email protected]

  • Resolves: ✨ Text app design review #1075
    Increase height of formatting bar to 50px, size of avatars to 44 (might fix the status bubble display issue too)
    A little transparency and blur for more open feel

  • Target version: master

Summary

  • Increase height of formatting bar to 50px, size of avatars to 44 (might fix the status bubble display issue too)
  • A little transparency and blur for more open feel

image

@juliusknorr
Copy link
Member

Having a bit of text in it I'm no longer sure if we should actually go with the blur here, which we initially discussed with @jancborchardt. Feels a bit less out of place compared to the general Nextcloud design:

Screen.Recording.2021-11-24.at.21.35.37.mov

@nimishavijay Maybe you also have some thoughts about that?

Other than that, there are a few further things that should be more aligned with the increase of the formatting buttons.

  • The menubar itself should only be 50px in total (including the padding)

Screenshot 2021-11-24 at 21 40 11

  • The avatars still seem to have a slightly different size and the user icon on the right some margin (the margin actually seems to be the reason that the menubar exceeds the 50px size)

Screenshot 2021-11-24 at 21 42 16

@nimishavijay
Copy link
Member

I think with text behind the formatting bar it is a bit confusing, because initially I couldn't tell that it was blurred text, I thought the colour of the bar changed to a weird grey. It looks really nice with images though.
I can also imagine it might be an accessibility issue because of insufficient contrast.

I suggest we do something like add gradient from 100% opacity at the middle of the formatting bar to 0% at the bottom along with the blur, so it is not a hard stop but a softer gradient. What do you think?

@luka-nextcloud
Copy link
Contributor Author

@jancborchardt @juliushaertl What do you think about @nimishavijay 's suggestion?
I think gradient opacity would look better.

@juliusknorr
Copy link
Member

I don't see a way with CSS to fade out the blur effect (which itself also doesn't work in some browsers). @jancborchardt Do you have strong feeling about the blur at all? I feel the design is much cleaner and more structured without now looking at the recording another time.

@jancborchardt
Copy link
Member

I don't see a way with CSS to fade out the blur effect (which itself also doesn't work in some browsers). @jancborchardt Do you have strong feeling about the blur at all? I feel the design is much cleaner and more structured without now looking at the recording another time.

Yeah, agree with you, don’t have a strong feeling about the blur – the current state looks better and less jarring. Similarly, as soon as the document is loaded, the header bar (where title and top right actions are in) should be fully opaque so the Nextcloud header does not shine through.

@juliusknorr juliusknorr added bug Something isn't working design Experience, interaction, interface, … 3. to review labels Jan 11, 2022
@juliusknorr juliusknorr added this to the Nextcloud 24 milestone Jan 11, 2022
@luka-nextcloud
Copy link
Contributor Author

@juliushaertl Please check again.

  1. Remove blur
  2. The menubar itself should only be 50px in total (including the padding)
  3. The avatars still seem to have a slightly different size and the user icon on the right some margin (the margin actually seems to be the reason that the menubar exceeds the 50px size)

@juliusknorr juliusknorr requested review from a team and azul January 14, 2022 20:47
@max-nextcloud
Copy link
Collaborator

/rebase

@max-nextcloud
Copy link
Collaborator

/compile amend /

@max-nextcloud
Copy link
Collaborator

@juliushaertl Please check again.
Since julius is out, i'll review.

Looks really goodat first sight. In particular scrolling workspaces without messing with the menubar is great.

  1. Remove blur

👍

  1. The menubar itself should only be 50px in total (including the padding)

Confirmed in viewer. looks good.
In the workspace it seems to be 44 (3 + 38 + 3) because there's no outer .menubar. Seems fine to me.

  1. The avatars still seem to have a slightly different size and the user icon on the right some margin (the margin actually seems to be the reason that the menubar exceeds the 50px size)

Confirmed. Changing the margin in SessionList.vue to margin: 0px 6px; centers the avatar. Reducing top of .save-status to 9px (6 less than before) ensures the status is still centered.

I'll create a new commit on top of this to apply these changes.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The top/bottom margin of .avatardiv.icon-group is 0 and the one of .avatar-wrapper is 6px so they are not aligned:
    ttt

As the menubar elements and the save-status are already aligned, we could just remove the margin of .avatar-wrapper:

.avatar-wrapper {
    margin: 0 -8px 0 0;
}
  1. Why not generating avatars in 44x44px instead of 32x32px in SessionList's template?

  2. Inline suggestions

@jancborchardt
Copy link
Member

as soon as the document is loaded, the header bar (where title and top right actions are in) should be fully opaque so the Nextcloud header does not shine through.

@luka-nextcloud is this something you could adjust here too? It’s sort of separate but makes the formatting bar look off since the Nextcloud header shines through above.

luka-nextcloud and others added 2 commits January 24, 2022 09:33
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@max-nextcloud
Copy link
Collaborator

I rebased and addressed all changes proposed by @eneiluj .

@max-nextcloud
Copy link
Collaborator

as soon as the document is loaded, the header bar (where title and top right actions are in) should be fully opaque so the Nextcloud header does not shine through.

@luka-nextcloud is this something you could adjust here too? It’s sort of separate but makes the formatting bar look off since the Nextcloud header shines through above.

My understanding is that the top header bar with hte nextcloud shining through is part of the viewer - not the text app. As far as i know we can only pick a light or a dark theme for the viewer.

@max-nextcloud
Copy link
Collaborator

2. Why not generating avatars in 44x44px instead of 32x32px in SessionList's template?

Yes... looks much better. Will do this.

@julien-nc julien-nc merged commit d2395aa into master Jan 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the update/formatting-bar branch January 24, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working design Experience, interaction, interface, …

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Text app design review

6 participants