Skip to content

feat(push): Optionally use OAEP padding#6139

Merged
mahibi merged 2 commits into
masterfrom
bugfix/noid/oaep-push
Apr 30, 2026
Merged

feat(push): Optionally use OAEP padding#6139
mahibi merged 2 commits into
masterfrom
bugfix/noid/oaep-push

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

@nickvergessen nickvergessen commented Apr 29, 2026

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@nickvergessen @claude
feat(push): Optionally use OAEP padding
8bab271 
Co-Authored-By: Claude Opus 4.7 <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the 24.0.0 milestone Apr 29, 2026
@nickvergessen nickvergessen self-assigned this Apr 29, 2026
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Apr 29, 2026
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 29, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt Outdated

private fun decryptSubject(privateKey: PrivateKey, base64DecodedSubject: ByteArray): ByteArray =
try {
val cipher = Cipher.getInstance("RSA/None/PKCS1Padding")
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/25114728585/artifacts/6710069920
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@nickvergessen nickvergessen mentioned this pull request Apr 29, 2026
Merged
@nickvergessen
Copy link
Copy Markdown
Member Author

nickvergessen commented Apr 29, 2026

✅ Confirmed via a test run on sermo

mahibi
mahibi approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine for both OAEP and PKCS1.

No hard feelings regarding the order, also fine to avoid the warning and check OAEP first

@mahibi
try OAEP first and PKCS1 as fallback.
8dbe9a5 
Also use OAEPWithSHA-1AndMGF1Padding instead of RSA/ECB/OAEPPadding

Signed-off-by: Marcel Hibbe <[email protected]>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/25159079583/artifacts/6727473090
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Codacy

Lint

TypemasterPR
Warnings8987
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5353
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8080

@mahibi mahibi merged commit dbfcdb6 into master Apr 30, 2026
16 of 20 checks passed
@mahibi mahibi deleted the bugfix/noid/oaep-push branch April 30, 2026 19:04
@nickvergessen nickvergessen mentioned this pull request May 4, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@mahibi mahibi mahibi approved these changes

+1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @AndyScherzinger @mahibi @github-advanced-security