Merged
Conversation
rullzer
reviewed
Sep 10, 2019
rullzer
reviewed
Sep 10, 2019
rullzer
reviewed
Sep 10, 2019
| // Have we sent more than three alerts in the last hour | ||
| $lastHour = count($this->mapper->findRecentByUid($uid, $now - 60 * 60)); | ||
| if ($lastHour >= 3) { | ||
| $this->logger->warning("Suspicious login peak detected: $uid received $lastTwoDays alerts in the last hour"); |
Member
There was a problem hiding this comment.
Suggested change
| $this->logger->warning("Suspicious login peak detected: $uid received $lastTwoDays alerts in the last hour"); | |
| $this->logger->warning("Suspicious login peak detected: $uid received $lastHour alerts in the last hour"); |
rullzer
requested changes
Sep 10, 2019
Member
rullzer
left a comment
There was a problem hiding this comment.
Overall looks good but the counting of the notifications is not right I think :P
Signed-off-by: Christoph Wurst <[email protected]>
a0d7c25 to
8d3b253
Compare
Member
Author
|
Please have another look.
|
rullzer
approved these changes
Sep 11, 2019
joshtrichards
added a commit
that referenced
this pull request
May 3, 2024
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Jul 2, 2024
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Jul 2, 2024
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
ChristophWurst
pushed a commit
that referenced
this pull request
Sep 30, 2024
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115