Add setup check for background blur#6517
Merged
nickvergessen merged 5 commits intomasterfrom Nov 17, 2021
Merged
Conversation
danxuliu
added
2. developing
bug
feature: settings ⚙️
This is just a formal rename of the methods to hint their intended visibility. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
add-setup-check-for-background-blur
branch
from
e6e96ce to
657b2d4
Compare
nickvergessen
requested changes
Nov 17, 2021
Member
Author
|
/backport to stable13 |
This was referenced Nov 17, 2021
Member
|
Time to fixup and "ready to review"? |
A new section is added to Talk administration settings for web server checks. The check creates a JitsiStreamBackgroundEffect object to ensure that the background blur files could be initialized, rather than implementing its own logic to verify the .wasm and .tflite files. Due to this, the browser running the check needs to support and have WebAssembly enabed, although it does not need to support the background blur itself (like Safari, which does not implement the needed canvas filters, but can anyway be used to do the check). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
add-setup-check-for-background-blur
branch
from
ed04447 to
0c3288a
Compare
Member
Author
I knew that I was forgetting something... 🤦 |
nickvergessen
approved these changes
Nov 17, 2021
|
The backport to stable13 failed. Please do this backport manually. |
Member
|
/backport to stable23 |
Member
|
Lets backport to 23 not 13 :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6503
Reviewers: this adds new strings! Also feel free to change them as needed, because I am not convinced by the texts I wrote :-P
Pending: