Conversation
Member
Author
|
@jancborchardt Needs CSS love… |
LukasReschke
force-pushed
the
make-user-autocomplete
branch
2 times, most recently
from
586f566 to
c3d87cf
Compare
Member
Author
|
To have this kinda performant nextcloud/server#1158 is required, aka: Use master. Not a stable branch 😉 |
Current coverage is 0.70% (diff: 100%)@@ master #55 diff @@
========================================
Files 8 8
Lines 283 283
Methods 22 22
Messages 0 0
Branches 0 0
========================================
Hits 2 2
Misses 281 281
Partials 0 0
|
LukasReschke
commented
Oct 17, 2016
| format: 'json', | ||
| search: term, | ||
| perPage: 200, | ||
| itemType: 'folder', |
LukasReschke
commented
Oct 17, 2016
|
|
||
| OCA.SpreedMe.Rooms.create(roomname); | ||
| $('#edit-roomname').on("select2-loaded", function() { | ||
| $('body').find('.avatar').each(function () { |
Member
Author
There was a problem hiding this comment.
Messy to have this three times here and above… Move into function or do some other kind of JS magic.
LukasReschke
commented
Oct 17, 2016
| return '<span><div class="avatar" data-user="' + escapeHTML(element.id) + '" data-user-display-name="' + escapeHTML(element.id) + '"></div>' + escapeHTML(element.id) + '</span>'; | ||
| }, | ||
| formatSelection: function (element) { | ||
| return '<span><div class="avatar" data-user="' + escapeHTML(element.id) + '" data-user-display-name="' + escapeHTML(element.id) + '"></div>' + escapeHTML(element.id) + '</span>'; |
Member
Author
There was a problem hiding this comment.
Guess proper templating helps 🙈
Member
There was a problem hiding this comment.
Btw, why is there a div (block-level element) in a span (inline element) ;) Shouldn’t be like that. Just make both elements divs.
LukasReschke
force-pushed
the
make-user-autocomplete
branch
from
c3d87cf to
4b089d8
Compare
This was referenced Oct 18, 2016
LukasReschke
force-pushed
the
make-user-autocomplete
branch
from
6e9750e to
3c10221
Compare
This adds a person selector as well as avatars so that initiating a call will be more intuitive. Fixes #25 Fixes #11 Signed-off-by: Lukas Reschke <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
LukasReschke
force-pushed
the
make-user-autocomplete
branch
from
3c10221 to
b4db524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a person selector as well as avatars so that initiating a call will be more intuitive. This is WIP and doesn't already do everything.
The idea is basically that by default you just type a name and then once you have completed that join a channel for those two people. The other person will then get a notification (to be done later) and a screen will be shown to the current user indicating that you're waiting until the other user joins the channel.
TODO
To create a group chat the three dot menu is currently being implemented by @Ivansss on another branch.
Fixes #25
Fixes #11
cc @jancborchardt @ChristophWurst FYI