Merged
Conversation
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Member
|
Works here, good to merge? |
Member
Author
|
Works fine here as well 👍 |
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
============================================
- Coverage 15.72% 15.46% -0.26%
- Complexity 269 274 +5
============================================
Files 17 18 +1
Lines 1272 1293 +21
============================================
Hits 200 200
- Misses 1072 1093 +21
Continue to review full report at Codecov.
|
| * @param string $callUser | ||
| * @return TemplateResponse | ||
| * @throws HintException | ||
| * @throws HintException|RedirectResponse |
Member
There was a problem hiding this comment.
it returns the response 😉
Member
|
@Ivansss now I see the problem. We have to add the tooltip to the second action too. Please create a ticket in the server repo and assign me. I'll take a look next week. Thanks :) |
Member
|
@Ivansss the tooltip is fixed to correct capitalized »Video call« now, right? ;) |
Member
Author
|
@jancborchardt yes :) it was changed here #303 |
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
Darken modal mask background for better focus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Uh oh!
There was an error while loading. Please reload this page.