Change status code when config is write protected#9996
Merged
MorrisJobke merged 1 commit intomasterfrom Jun 26, 2018
Merged
Conversation
Add hint msg, you can make config file read only If the config.php is not writable, print an error message: #6893 - set config writable - or set option to keep it read only Signed-off-by: Eric Masseran <[email protected]>
MorrisJobke
requested review from
juliusknorr,
nickvergessen,
rullzer and
skjnldsv
Member
Author
|
👍 from me as well, because I basically only squashed the commits and did some whitespace changes. |
MorrisJobke
added
4. to release
juliusknorr
approved these changes
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hint msg, you can make config file read only
If the config.php is not writable, print an error message: #6893
Re-submit of #7205 with fixed style and extracted part - see #9995
cc @Morikko