Merged
Conversation
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
techdep/noid/appframework_mapper_to_qb
branch
from
1a4261e to
610c665
Compare
Codecov Report
@@ Coverage Diff @@
## master #9444 +/- ##
============================================
- Coverage 51.61% 51.57% -0.04%
- Complexity 25694 25712 +18
============================================
Files 1638 1639 +1
Lines 96318 96398 +80
Branches 1393 1393
============================================
+ Hits 49712 49716 +4
- Misses 46606 46682 +76
|
MorrisJobke
approved these changes
May 14, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense 👍 - please add it to the docs.
MorrisJobke
reviewed
May 14, 2018
| $getter = 'get' . ucfirst($property); | ||
| $value = $entity->$getter(); | ||
|
|
||
| $qb->setValue($column, $qb->createNamedParameter($value)); |
Member
There was a problem hiding this comment.
SqlInjectionChecker Potential SQL injection detected - method: no child method
MorrisJobke
reviewed
May 14, 2018
| $getter = 'get' . ucfirst($property); | ||
| $value = $entity->$getter(); | ||
|
|
||
| $qb->set($column, $qb->createNamedParameter($value)); |
Member
There was a problem hiding this comment.
SqlInjectionChecker Potential SQL injection detected - method: no child method
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when I wanted to log the queries we make that not all of them are logged. Then I remembered that the Mapper doesn't use the query builder yet. So I decided to add a new one.
We should probably add tests.