Merged
Conversation
…emes anymore Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
deprecate-theme-sync-clients
branch
from
39054fe to
cf4d27b
Compare
rullzer
approved these changes
Mar 26, 2018
skjnldsv
approved these changes
Mar 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #8994 +/- ##
============================================
- Coverage 53.58% 51.95% -1.63%
- Complexity 23981 25323 +1342
============================================
Files 1443 1603 +160
Lines 80307 95117 +14810
Branches 0 1388 +1388
============================================
+ Hits 43030 49417 +6387
- Misses 37277 45700 +8423
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there were two options to configure links to custom clients, using a config.php parameter and in a custom theme. This PR will use the customclient_* parameters of config.php by default if set and deprecate the ability to overwriting those in custom themes.