Skip to content

Comments

Remove deprecated HTTPHelper#8804

Merged
rullzer merged 2 commits intomasterfrom
remove_httphelper
Mar 14, 2018
Merged

Remove deprecated HTTPHelper#8804
rullzer merged 2 commits intomasterfrom
remove_httphelper

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Mar 13, 2018

  • Remove the HTTP Helper
  • Remove from Server Containter
  • Removed legacy share tests that use it

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer rullzer added this to the Nextcloud 14 milestone Mar 13, 2018
@rullzer
Remove deprecated HTTPHelper
7785c37 
* Remove the HTTP Helper
* Remove from Server Containter
* Removed legacy share tests that use it

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the remove_httphelper branch from dffac1d to 7785c37 Compare March 13, 2018 20:55
@codecov
Copy link

codecov bot commented Mar 13, 2018 •
edited
Loading

Codecov Report

Merging #8804 into master will decrease coverage by 20.47%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #8804       +/-   ##
=============================================
- Coverage     51.96%   31.49%   -20.48%     
+ Complexity    25287    25278        -9     
=============================================
  Files          1607     1606        -1     
  Lines         94829    94801       -28     
  Branches       1377     1377               
=============================================
- Hits          49281    29854    -19427     
- Misses        45548    64947    +19399
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 17.91% <ø> (-65.21%) 278 <0> (-2)
lib/private/Share/Share.php 0.27% <0%> (-66.02%) 405 <0> (+1)
apps/files_trashbin/lib/Command/Expire.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Comments/ManagerFactory.php 0% <0%> (-100%) 2% <0%> (ø)
...public/AppFramework/OCS/OCSBadRequestException.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
apps/comments/lib/AppInfo/Application.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Settings/Admin.php 0% <0%> (-100%) 5% <0%> (ø)
apps/user_ldap/lib/LDAPProviderFactory.php 0% <0%> (-100%) 2% <0%> (ø)
lib/public/Comments/CommentsEvent.php 0% <0%> (-100%) 3% <0%> (ø)
... and 372 more

@MorrisJobke MorrisJobke mentioned this pull request Mar 13, 2018
Closed
@rullzer
Replace ContactsManager
b93d26a 
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 14, 2018
MorrisJobke
MorrisJobke approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

ChristophWurst
ChristophWurst approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

@rullzer rullzer merged commit 0e48afa into master Mar 14, 2018
@rullzer rullzer deleted the remove_httphelper branch March 14, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @MorrisJobke @ChristophWurst