Conversation
Codecov Report
@@ Coverage Diff @@
## master #8793 +/- ##
============================================
+ Coverage 51.89% 51.89% +<.01%
- Complexity 25267 25268 +1
============================================
Files 1605 1605
Lines 94771 94774 +3
Branches 1377 1377
============================================
+ Hits 49180 49183 +3
Misses 45591 45591
|
icewind1991
left a comment
icewind1991
left a comment
There was a problem hiding this comment.
While the swift library does use container, the connection logic will properly use bucket when available and the multi bucket code works with bucket
So in the config using bucket would be prefered, for the cacheKey container is good.
|
@icewind1991 in that case also need to be properly fixed... I don't care what we use but this mixing and matching has to be cleaned up |
|
The setup code sets For new setups |
|
Ok then let me fix it all in one go... because currently we also get a 'non defined offset' with the code |
|
@icewind1991 please have another look this should do the trick then... |
| $this->params['container'] = $this->params['bucket']; | ||
| } | ||
| if (!isset($this->params['container'])) { | ||
| $this->params['container'] = 'owncloud'; |
There was a problem hiding this comment.
there is a small chance that changing this will break an existing installation
There was a problem hiding this comment.
well fair enough. But I guess we don't want new users to create an owncloud container. We could just put it in the release notes that we require them to set the container/bucket variable properly.
Signed-off-by: Roeland Jago Douma <[email protected]>
3 participants
Signed-off-by: Roeland Jago Douma [email protected]