Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8614 +/- ##
============================================
+ Coverage 51.93% 51.94% +<.01%
Complexity 25422 25422
============================================
Files 1609 1609
Lines 95343 95343
Branches 1378 1378
============================================
+ Hits 49521 49522 +1
+ Misses 45822 45821 -1
|
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
nickvergessen
rullzer
added
3. to review
juliusknorr
reviewed
Mar 2, 2018
lib/private/Mail/Message.php
Outdated
| * @return $this | ||
| */ | ||
| public function setSubject($subject) { | ||
| public function setSubject($subject): IMessage { |
Member
There was a problem hiding this comment.
I guess $subject should always be a string.
nickvergessen
previously requested changes
Mar 2, 2018
lib/private/Mail/EMailTemplate.php
Outdated
| * @since 12.0.0 | ||
| */ | ||
| public function addBodyListItem($text, $metaInfo = '', $icon = '', $plainText = '', $plainMetaInfo = '') { | ||
| public function addBodyListItem(string $text, string $metaInfo = '', string $icon = '', string $plainText = '', string $plainMetaInfo = '') { |
Member
There was a problem hiding this comment.
$plain* can also be false here, sorry
lib/public/Mail/IEMailTemplate.php
Outdated
| * @since 12.0.0 | ||
| */ | ||
| public function addBodyListItem($text, $metaInfo = '', $icon = '', $plainText = '', $plainMetaInfo = ''); | ||
| public function addBodyListItem(string $text, string $metaInfo = '', string $icon = '', string $plainText = '', string $plainMetaInfo = ''); |
Member
There was a problem hiding this comment.
$plain* can also be false here, sorry
* Fix typehints * Made strict Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Member
Author
|
Another round :D |
ChristophWurst
approved these changes
Mar 5, 2018
MorrisJobke
approved these changes
Mar 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma [email protected]