Merged
Conversation
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
nickvergessen
nickvergessen
approved these changes
Feb 21, 2018
Member
Author
|
Mmmm errors. lets me dive into that. |
rullzer
added
2. developing
Signed-off-by: Roeland Jago Douma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #8476 +/- ##
============================================
- Coverage 51.81% 51.75% -0.06%
Complexity 25362 25362
============================================
Files 1601 1601
Lines 95017 95018 +1
Branches 1377 1377
============================================
- Hits 49233 49179 -54
- Misses 45784 45839 +55
|
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
added
3. to review
Signed-off-by: Roeland Jago Douma <[email protected]>
Member
Author
|
Only https://drone.nextcloud.com/nextcloud/server/5077/244 fails which is unrelated |
ChristophWurst
approved these changes
Feb 21, 2018
Member
|
I wonder how many apps have the wrong usage of the parameter (not array) 🙈 |
Member
Author
|
@nickvergessen yeah it is a shame that we can't het real function overloading. Then we could just write two. But the phpdoc has been like this for ages. So I would say we are fine here. We just need to make sure people test their apps well ahead of 14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma [email protected]