Conversation
MorrisJobke
commented
Dec 4, 2017
- first commit is only cleanup
|
@nickvergessen @rullzer I would say, that we should first get this in and then have followup PRs that add the strict typing to subtrees of our code. |
|
Or should we already add |
|
Do we need to add it to each file? |
Yes. |
|
I shall run my other script than to update the php testing versions in travis.yml for all apps on master I guess 🙊 |
There is a PHPStorm inspection for this: https://stackoverflow.com/a/43281565/520507 |
Added here: #7808 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #7392 +/- ##
============================================
- Coverage 52.07% 6.63% -45.45%
+ Complexity 25984 25347 -637
============================================
Files 1651 1607 -44
Lines 95983 95315 -668
Branches 1290 1394 +104
============================================
- Hits 49983 6324 -43659
- Misses 46000 88991 +42991
|
dd3ea06 to
0e3aad2
Compare
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
|
Nothing for 14 it seems -> moved to 15 It's an ongoing improvement ;) |