fix design details in comments sidebar#714
Conversation
|
@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @vincchan and @MorrisJobke to be potential reviewers |
jancborchardt
added
enhancement
design
| ' <form class="newCommentForm">' + | ||
| ' <textarea class="message" placeholder="{{newMessagePlaceholder}}">{{{message}}}</textarea>' + | ||
| ' <input class="submit" type="submit" value="{{submitText}}" />' + | ||
| ' <input type="text" class="message" placeholder="{{newMessagePlaceholder}}" value="{{{message}}}"" />' + |
|
looks really nice and works! :) 👍 |
|
failing test PhantomJS 2.1.1 (Linux 0.0.0) OCA.Comments.CommentsTabView tests editing comments saves message and updates comment item when clicking save FAILED EDIT: also when we're on the subject editing comments looks a bit weird atm compared to newcomments form
|
|
Looks much nicer, Works |
|
-.- Oh ... it was already reported. @jancborchardt Please fix this ;) |
MorrisJobke
added
2. developing
|
Beside that it looks nice :) |
rullzer
force-pushed
the
comments-layout
branch
from
b71f990 to
eab3ae5
Compare
Only because it is an input now so you can now longer format text (newlines). I don't really have an opinion here. But let you all decide. Review time |
rullzer
added
3. to review
rullzer
force-pushed
the
comments-layout
branch
from
eab3ae5 to
0d96478
Compare
* tested in IE10, IE11, Edge, Chrome and Firefox
|
I fixed the layout of the submit button and tested it in IE10, 11, Edge, Chrome and Firefox. It now also works properly for all screen sizes. Before & After:
|
|
I also fixed the layout of the cancel button (pulled to right and properly aligned). I tested this in Chrome, Firefox, Safari, IE10 and Edge. Before and after:
|
|
I tested it and it now works really great 👍 from me |
|
LGTM! |
|
This still had open comments... Will fix #714 (comment) |
|
Fix in #928 |
fix design details in comments sidebar
8 participants
Currently there’s a textarea for comment posting in the sidebar. I’d say we only use an input field to encourage short and concise comments.
When we use comments in the Activity app etc, we can use textareas, but not in smaller areas like the sidebar.
Then also pressing enter now sends the message, much quicker.
And the layout is improved overall. Focus on the message rather than author and date, which only get half opacity.
Before & after:
Please review @nextcloud/designers :)