Skip to content

Comments

Allow apps to have their own autoloader#6853

Merged
LukasReschke merged 4 commits intomasterfrom
apps_autoloader
Oct 19, 2017
Merged

Allow apps to have their own autoloader#6853
LukasReschke merged 4 commits intomasterfrom
apps_autoloader

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 17, 2017 •
edited
Loading

On our current setup we do over 500 calls to find_file for autoloading. This seems a bit to excessive and is not required IMO.

In case there is a file called: <appdir>/composer/autoload.php we will load that as the autoloader for this app.

If you have this autoloader file we will no longer load via the legacy autoloader.

  • First commit is the actual change
  • Second commit moves over files_sharing

Comments are welcome.

Todo:

  • Add to build/autoloa.....sh
  • Exclude composer stuff from phan

@rullzer rullzer added this to the Nextcloud 13 milestone Oct 17, 2017
@nickvergessen
Copy link
Member

nickvergessen commented Oct 17, 2017

Can we add the generation of this to build/autoloa.....sh please?

@rullzer
Allow apps to have their own autoloader
3a9c24c 
This will allow apps to also have a proper classmap and authorative
autoloader.

Currently if a file: <appdir>/composer/autoload.php exists we will use
it. Else we keep the current behavior.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer
Move files_sharing to a proper classmap
f51eccf 
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer
Update autoload checker
5d7d96d 
Signed-off-by: Roeland Jago Douma <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2017 •
edited
Loading

Codecov Report

Merging #6853 into master will decrease coverage by 0.14%.
The diff coverage is 1.24%.

@@             Coverage Diff             @@
##             master   #6853      +/-   ##
===========================================
- Coverage     53.05%   52.9%   -0.15%     
- Complexity    22688   22765      +77     
===========================================
  Files          1430    1437       +7     
  Lines         88218   88457     +239     
  Branches       1349    1349              
===========================================
- Hits          46802   46797       -5     
- Misses        41416   41660     +244
Impacted Files Coverage Δ Complexity Δ
.../files_sharing/composer/composer/autoload_psr4.php 0% <0%> (ø) 0 <0> (?)
...iles_sharing/composer/composer/autoload_static.php 0% <0%> (ø) 1 <1> (?)
apps/files_sharing/composer/autoload.php 0% <0%> (ø) 0 <0> (?)
..._sharing/composer/composer/autoload_namespaces.php 0% <0%> (ø) 0 <0> (?)
.../files_sharing/composer/composer/autoload_real.php 0% <0%> (ø) 11 <11> (?)
...es_sharing/composer/composer/autoload_classmap.php 0% <0%> (ø) 0 <0> (?)
...ps/files_sharing/composer/composer/ClassLoader.php 0% <0%> (ø) 64 <64> (?)
lib/private/legacy/app.php 53.58% <75%> (-0.02%) 223 <0> (+1)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
... and 9 more

@rullzer
Ignore composer stuff in phan
ff9f325 
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer
Copy link
Member Author

rullzer commented Oct 18, 2017

@nickvergessen updated

nickvergessen
nickvergessen approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharing still works

@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 18, 2017
@rullzer
Copy link
Member Author

rullzer commented Oct 18, 2017

K lets do this. Then I can slowly migrate the other apps later :)

@rullzer rullzer changed the title [PoC] Allow apps to have their own autoloader Allow apps to have their own autoloader Oct 18, 2017
@LukasReschke LukasReschke merged commit f6f7b50 into master Oct 19, 2017
@LukasReschke LukasReschke deleted the apps_autoloader branch October 19, 2017 09:05
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jan 12, 2023
@ChristophWurst ChristophWurst mentioned this pull request Jan 12, 2023
Merged
4 tasks
@ChristophWurst ChristophWurst mentioned this pull request Jan 20, 2023
Merged
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 20, 2023 •
edited
Loading

Docs at nextcloud/documentation#9573. Welcome to the feature future

@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jan 20, 2023
@ChristophWurst ChristophWurst mentioned this pull request Jun 7, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement technical debt

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @nickvergessen @ChristophWurst @LukasReschke