Merged
Conversation
rullzer
added
3. to review
rullzer
requested review from
LukasReschke,
MorrisJobke,
icewind1991 and
nickvergessen
Signed-off-by: Roeland Jago Douma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5836 +/- ##
============================================
+ Coverage 53.81% 53.82% +<.01%
- Complexity 22732 22734 +2
============================================
Files 1403 1403
Lines 86644 86648 +4
Branches 1327 1327
============================================
+ Hits 46629 46636 +7
+ Misses 40015 40012 -3
|
icewind1991
approved these changes
Jul 25, 2017
LukasReschke
approved these changes
Jul 25, 2017
Member
|
@rullzer Could you open the backport PR? |
Member
Author
|
Backport in #5945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We killed off the full wildcard search. So the preview cleanup should properly traverse.