(feat) setup appdata folder based on config#57747
(feat) setup appdata folder based on config#57747akhil1508 wants to merge 1 commit intonextcloud:masterfrom
Conversation
akhil1508
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
akhil1508
force-pushed
the
dev/custom-appdata
branch
from
4bde0d8 to
807619e
Compare
| @@ -424,10 +424,26 @@ public function setupRoot(): void { | |||
| foreach ($rootMounts as $rootMountProvider) { | |||
| $this->mountManager->addMount($rootMountProvider); | |||
| } | |||
|
|
|||
| $this->setupAppData(); | |||
There was a problem hiding this comment.
I don't know if this is the right place to do this mount setup. setupRoot doesn't have any events to hook into either.
But if we do it in AppData.php like in #36337, occ files:scan-app-data stops working since that command does a tearDownFS and setupFS.
Whereas $setupManager->setupRoot() seems to me is completed generally for all requests, commands and background jobs.
Please suggest a better approach if possible :)
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Akhil <[email protected]>
akhil1508
force-pushed
the
dev/custom-appdata
branch
from
807619e to
1f60b7e
Compare
1 participant
Summary
appdata_[instanceid]folder #36337TODO
Checklist
3. to review, feature component)stable32)