Skip to content

Comments

chore: update @nextcloud/eslint-config to v9.0.0-rc.6 and fix issues#56660

Merged
susnux merged 5 commits intomasterfrom
chore/eslint-config
Nov 25, 2025
Merged

chore: update @nextcloud/eslint-config to v9.0.0-rc.6 and fix issues#56660
susnux merged 5 commits intomasterfrom
chore/eslint-config

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 25, 2025 •
edited
Loading

  • update config
  • auto fix issues
  • base line legacy issues

Checklist

@susnux susnux requested a review from skjnldsv as a code owner November 25, 2025 13:14
@susnux susnux added the 3. to review Waiting for reviews label Nov 25, 2025
@susnux susnux requested review from a team as code owners November 25, 2025 13:14
@susnux susnux added dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 25, 2025
@susnux susnux requested review from leftybournes, nfebe, salmart-dev, szaimen and yemkareems and removed request for a team November 25, 2025 13:14
@susnux susnux mentioned this pull request Nov 25, 2025
Merged
6 tasks
szaimen
szaimen approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux added this to the Nextcloud 33 milestone Nov 25, 2025
ShGKme
ShGKme reviewed Nov 25, 2025
View reviewed changes
apps/settings/src/components/PersonalInfo/BirthdaySection.vue
Comment on lines +16 to 17
:model-value="value"
@input="onInput" />
Copy link
Contributor

@ShGKme ShGKme Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should also check the events in the plugin.

ShGKme
ShGKme reviewed Nov 25, 2025
View reviewed changes
apps/settings/src/components/SelectSharingPermissions.vue Outdated
<template>
<fieldset class="permissions-select">
<NcCheckboxRadioSwitch :checked="canCreate" @update:checked="toggle(PERMISSION_CREATE)">
<NcCheckboxRadioSwitch :model-value="canCreate" @update:checked="toggle(PERMISSION_CREATE)">
Copy link
Contributor

@ShGKme ShGKme Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting modelValue but handling update:checked feels incorrect even it works

Copy link
Contributor Author

@susnux susnux Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW we still do not support @update:model-value this is never emitted. Only @update:modelValue is for Vue 2.

Copy link
Contributor Author

@susnux susnux Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting modelValue but handling update:checked feels incorrect even it works

(Rebased and additionally) added a new commit manually adjusting those events.

Copy link
Contributor

@ShGKme ShGKme Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW we still do not support @update:model-value this is never emitted. Only @update:modelValue is for Vue 2.

Are you sure?
The migration composable doe emit it. It is only skipped in components initially using update:modelValue

Copy link
Contributor Author

@susnux susnux Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was pretty sure that it did not work when I was testing it, but now I cannot reproduce 🤔

@susnux susnux force-pushed the chore/eslint-config branch from 19ac884 to 6bcc00d Compare November 25, 2025 14:27
@susnux
Copy link
Contributor Author

susnux commented Nov 25, 2025

/compile

@susnux susnux force-pushed the chore/eslint-config branch from 6bcc00d to f1d2833 Compare November 25, 2025 15:25
@nextcloud-command
chore(assets): Recompile assets
93dadb3 
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 8b293d1 into master Nov 25, 2025
155 of 159 checks passed
@susnux susnux deleted the chore/eslint-config branch November 25, 2025 18:40
@skjnldsv
Copy link
Member

skjnldsv commented Dec 10, 2025 •
edited
Loading

Since this PR I get errors like those when opening the basic settings @susnux :

image

@susnux
Copy link
Contributor Author

susnux commented Dec 10, 2025

Since this PR I get errors like those when opening the basic settings

I cannot see any changed for value props but both messages look like they are always an error, because this PR did not touch any casting of values.

But where did you see this messages? I looked through all settings and could not find this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux @skjnldsv @ShGKme @szaimen @nextcloud-command