refactor(user_status): migrate to Vue 3#56544
Merged
nickvergessen merged 5 commits intomasterfrom Nov 26, 2025
Merged
Conversation
ShGKme
force-pushed
the
chore/user_status--vue3
branch
2 times, most recently
from
fa9056c to
b837912
Compare
susnux
reviewed
Nov 20, 2025
ShGKme
added
3. to review
ShGKme
force-pushed
the
chore/user_status--vue3
branch
from
b837912 to
5ca53f4
Compare
ShGKme
force-pushed
the
fix/build-vite-chunks
branch
from
06cbc16 to
d54009f
Compare
ShGKme
force-pushed
the
chore/user_status--vue3
branch
2 times, most recently
from
b78f534 to
2515803
Compare
Contributor
Author
|
/compile |
ShGKme
requested review from
Altahrim,
CarlSchwan,
nfebe,
sorbaugh and
szaimen
and removed request for
a team
Contributor
|
/compile rebase |
susnux
approved these changes
Nov 25, 2025
Contributor
Author
|
cc @Antreesy as an app owner |
susnux
force-pushed
the
chore/user_status--vue3
branch
from
b03e6f9 to
f008810
Compare
Contributor
|
Added a commit because lint is red unrelated - this will be fixed in a different PR. |
Contributor
|
Proper fix: #56660 |
Antreesy
reviewed
Nov 25, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Works with mentioned changes
Contributor
Author
|
I was sure, I did all these changes... |
ShGKme
force-pushed
the
chore/user_status--vue3
branch
from
ae13758 to
8493eeb
Compare
Contributor
Author
|
susnux
approved these changes
Nov 25, 2025
skjnldsv
reviewed
Nov 26, 2025
| 'settings-admin': resolve(import.meta.dirname, 'apps/user_ldap/src', 'settings-admin.ts'), | ||
| }, | ||
| user_status: { | ||
| menu: resolve(import.meta.dirname, 'apps/user_status/src', 'menu.js'), |
Contributor
There was a problem hiding this comment.
Since this is another big chunk of work, I will tackle it later and separately
Contributor
Author
There was a problem hiding this comment.
Yes, the goal of this PR is to migrate the app to Vue 3 with minimal changes. There is much to refactor in this app, but it could be done before and can be done after the Vue 3 migration
6 tasks
skjnldsv
approved these changes
Nov 26, 2025
ShGKme
force-pushed
the
chore/user_status--vue3
branch
from
8493eeb to
ddece38
Compare
Contributor
Author
|
Contributor
Yes, thank you :) |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Antreesy
force-pushed
the
chore/user_status--vue3
branch
from
ddece38 to
8ca4a7a
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Contributor
I am always impressed about that, but I guess its only source maps 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountMenuEntryis not fully compatible with Vue 3, expecting menu items to be replaced when mounted in place, not to be mounted inside the entryuser_statustocoreto avoid illegal import (core should not depend on an app)box-sizing: border-boxaddedChecklist
3. to review, feature component)stable32)